Uncapped length of skin data fields submitted by players
Affecting pocketmine/pocketmine-mp package on Packagist
Context / Overview
Impact
Some skin data fields (e.g. skinID, geometryName) are not capped in length. These fields are typically saved in the NBT data of a player when the player quits the server, or during an autosave.
This is problematic due to the 32767 byte limit on TAG_Strings. If any of these fields exceeds 32767 bytes, an exception will be thrown during data saving, which will cause the server to crash.
Other fields (such as skinGeometryData) are also uncapped, but those have a much larger 2 GB length limit, so this is not a concern for those, particularly considering the decompressed packet size limit of 2 MB.
Patches
PM3: 958a9dbf0fe3131ab60319c5a939f5dfbfe5dfbb PM4: 6492cac5c10f9fa8443ceddd2191a7b65b73f601
Workarounds
A plugin may check player skins during PlayerLoginEvent and PlayerSkinChangeEvent and ensure that the offending fields are not larger than 32767 bytes.
For more information
If you have any questions or comments about this advisory:
- Email us at team@pmmp.io
Jit Recommended Tools
OSV-Scanner
Objective: Dependency check (SCA)
Description: OSV-Scanner provides an officially supported frontend to the OSV database that connects a project’s list of dependencies with the vulnerabilities that affect them. Since the OSV.dev database is open source and distributed, it has several benefits in comparison with closed source advisory databases and scanners:
Vulnerability Layer - SCA
SCA Dependency Check is one of the important tools used to identify vulnerabilities in open-source components used in software applications. However, it primarily focuses on identifying vulnerabilities in the dependency layer of the software application. In contrast, code vulnerability layer analysis is focused on identifying vulnerabilities in the source code of the application itself, rather than the dependencies it uses. It typically involves analyzing the source code to identify security issues such as buffer overflows, injection vulnerabilities, and authentication issues, among others. While SCA Dependency Check is an important tool in identifying vulnerabilities in open-source dependencies, it may not be sufficient to ensure the overall security of the software application. To ensure comprehensive security, it is important to also perform code vulnerability layer analysis to identify vulnerabilities in the source code of the application. Incorporating both SCA Dependency Check and code vulnerability layer analysis into the software development lifecycle can help ensure that vulnerabilities are identified and remediated at both the dependency and code layers of the application. This can help prevent security issues from being introduced into the final product and improve the overall security posture of the software application.
