elFinder unsafe upload filtering leading to remote code execution
Affecting studio-42/elfinder package on Packagist
Context / Overview
Impact
Before elFinder 2.1.58, the upload filter did not disallow the upload of .phar files. As several Linux distributions are now shipping Apache configured in a way it will process these files as PHP scripts, attackers could gain arbitrary code execution on the server hosting the PHP connector (even in minimal configuration).
Patches
The issue has been addressed with https://github.com/Studio-42/elFinder/commit/75ea92decc16a5daf7f618f85dc621d1b534b5e1, associating .phar files to the right MIME type. Unless explicitly allowed in the configuration, such files cannot be uploaded anymore. This patch is part of the last release of elFinder, 2.1.58.
Workarounds
If you can't update to 2.1.58, make sure your connector is not exposed without authentication.
Important tips
Server-side scripts can often be created as text files. Currently, elFinder has an appropriate MIME type set for file extensions that are generally runnable on a web server.
However, the server has various settings. In some cases, the executable file may be judged as "text/plain". Therefore, elFinder installers should understand the extensions that can be executed on the web server where elFinder is installed, and check if there are any missing items in the elFinder settings.
The elFinder PHP connector has an option "additionalMimeMap" that specifies the MIME type for each extension. See #3295(comment) for more information.
References
- https://snyk.io/vuln/composer:studio-42%2Felfinder
- https://github.com/Studio-42/elFinder/issues/3295
- Further technical details will be disclosed on https://blog.sonarsource.com/tag/security after some time.
For more information
If you have any questions or comments about this advisory, you can contact:
- The original reporters, by sending an email to support [at] snyk.io or vulnerability.research [at] sonarsource.com;
- The maintainers, by opening an issue on this repository.
Jit Recommended Tools
OSV-Scanner
Objective: Dependency check (SCA)
Description: OSV-Scanner provides an officially supported frontend to the OSV database that connects a project’s list of dependencies with the vulnerabilities that affect them. Since the OSV.dev database is open source and distributed, it has several benefits in comparison with closed source advisory databases and scanners:
Vulnerability Layer - SCA
SCA Dependency Check is one of the important tools used to identify vulnerabilities in open-source components used in software applications. However, it primarily focuses on identifying vulnerabilities in the dependency layer of the software application. In contrast, code vulnerability layer analysis is focused on identifying vulnerabilities in the source code of the application itself, rather than the dependencies it uses. It typically involves analyzing the source code to identify security issues such as buffer overflows, injection vulnerabilities, and authentication issues, among others. While SCA Dependency Check is an important tool in identifying vulnerabilities in open-source dependencies, it may not be sufficient to ensure the overall security of the software application. To ensure comprehensive security, it is important to also perform code vulnerability layer analysis to identify vulnerabilities in the source code of the application. Incorporating both SCA Dependency Check and code vulnerability layer analysis into the software development lifecycle can help ensure that vulnerabilities are identified and remediated at both the dependency and code layers of the application. This can help prevent security issues from being introduced into the final product and improve the overall security posture of the software application.
